Skip to content

C#: Re-factor data flow unit tests to use the new API. #12732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 13, 2023

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Mar 31, 2023

In this PR we refactor

  • Unit tests
  • Inline flow test framework
    to the new data flow API.

Note that the inline flow test output has changed. The inline flow tests had two similar configurations in scope during execution which caused the duplicate nodes and edges (these are now removed from the test output).

@github-actions github-actions bot added the C# label Mar 31, 2023
@michaelnebel michaelnebel force-pushed the csharp/refactorunittests branch from 446ecdb to c787bb2 Compare April 12, 2023 09:47
@michaelnebel michaelnebel marked this pull request as ready for review April 13, 2023 08:04
@michaelnebel michaelnebel requested a review from a team as a code owner April 13, 2023 08:04
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelnebel michaelnebel merged commit 2d2d32a into github:main Apr 13, 2023
@michaelnebel michaelnebel deleted the csharp/refactorunittests branch April 13, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants