Skip to content

Swift: Rewrite more queries to use DataFlow::ConfigSig #12749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 4, 2023

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Apr 3, 2023

Note that the QLDoc CI failure is expected. We're omitting QLDoc for predicates that implement a signature and our tooling currently expects QLDoc although this can be taken from the signature. This is a known issue. See also here: #12541 (comment)

@github-actions github-actions bot added the Swift label Apr 3, 2023
@jketema jketema marked this pull request as ready for review April 4, 2023 07:11
@jketema jketema requested a review from a team as a code owner April 4, 2023 07:11
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MathiasVP MathiasVP merged commit 03c2837 into github:main Apr 4, 2023
@jketema jketema deleted the swift-config branch April 4, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants