Ruby/QL: Share dbscheme generation code #12765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are currently duplicated across the Ruby and QL extractors. Adding them to the shared extractor library will get rid of this duplication.
These now live in the shared extractor library.
These now live in the shared extractor library.
Remove unnecessary borrows and lifetime specifiers.
Use clearer methods where appropriate.
aibaars
approved these changes
Apr 5, 2023
| }; | ||
| (case, table) | ||
| } | ||
| use codeql_extractor::generator::{generate, language::Language}; | ||
|
|
||
| fn main() -> std::io::Result<()> { | ||
| tracing_subscriber::fmt() |
There was a problem hiding this comment.
I guess we should also factor out all the command line argument and logger setup code. Feel free to postpone that to a follow-up PR though.
There was a problem hiding this comment.
Yes, I've got plans for this in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further consolidates the extractor code into the shared library.