-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Javascript: Add new queries for Javascript actions #12781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kevinbackhouse @JarLob - I have added the sinks that are of higher priority here. During the analysis - we also marked some lower-priority sinks (things such as |
I think it's better to start with just the high-priority ones, so that you have a lower false-positive rate. |
srcidx = source.getNode().asExpr() and envname = srcidx.getPropertyName() | ||
or | ||
srcdot = source.getNode().asExpr() and envname = srcdot.getPropertyName() |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reformatting of the added lines may be needed.
javascript/ql/src/experimental/Security/CWE-094/ActionsContextToSink.ql
Outdated
Show resolved
Hide resolved
javascript/ql/src/experimental/Security/CWE-094/ActionsContextToSink.ql
Outdated
Show resolved
Hide resolved
Co-authored-by: Jaroslav Lobačevski <jarlob@github.com>
…ToSink.ql Co-authored-by: Jaroslav Lobačevski <jarlob@github.com>
…ToSink.ql Co-authored-by: Jaroslav Lobačevski <jarlob@github.com>
javascript/ql/src/experimental/Security/CWE-094/ActionsContextToSink.ql
Outdated
Show resolved
Hide resolved
…ToSink.ql Co-authored-by: Jaroslav Lobačevski <jarlob@github.com>
First of all, sorry for the long radio silence. These models seem very valuable, and I'd like to get them into the mainline outside experimental. However, I foresee some issues with code duplication, since this PR adds new variants of existing queries containing sinks we already have models for. It's difficult for us to maintain code with such duplication. Rather than merging to experimental and then do a round of clean-up afterwards, I've opened a PR adding the new sources as well as I haven't ported the "Actions Environment to Sink" query as I'm still not quite sure what the threat model is, but I'm thinking it could be part of |
Closing this. since we have #12978 |
Added 3 Queries, that track flows from -