Skip to content

Swift: Extract structured keypath components. #12784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Swift: Extract structured keypath components. #12784

merged 5 commits into from
Apr 12, 2023

Conversation

sashabu
Copy link
Contributor

@sashabu sashabu commented Apr 6, 2023

No description provided.

@github-actions github-actions bot added the Swift label Apr 6, 2023
@sashabu sashabu added the no-change-note-required This PR does not need a change note label Apr 11, 2023
sashabu added 2 commits April 11, 2023 13:34
Preexisting errors are left to be fixed later.
Changes in swift/ql/lib are generated by swift/codegen without manual intervention.
…tion.

I've marked both scripts as "partial" since we're extracting different AST components for key-paths and don't have a good way to convert between them in QL. Each deletes the corresponding tables, but leaves non-key-path functionality intact.
@sashabu sashabu removed the no-change-note-required This PR does not need a change note label Apr 11, 2023
@sashabu sashabu requested a review from MathiasVP April 11, 2023 13:12
@sashabu sashabu marked this pull request as ready for review April 11, 2023 13:26
@sashabu sashabu requested a review from a team as a code owner April 11, 2023 13:26
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, but otherwise this LGTM!

@sashabu sashabu requested a review from MathiasVP April 12, 2023 11:06
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, but otherwise this LGTM!

@sashabu sashabu requested a review from MathiasVP April 12, 2023 11:51
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@sashabu sashabu merged commit f4b79ea into main Apr 12, 2023
@sashabu sashabu deleted the sashabu/keypaths branch April 12, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants