Turn inline expectation test into a parameterized module #12789
Conversation
| predicate hasOptionalResult(Location location, string element, string tag, string value) { | ||
| none() | ||
| } | ||
| predicate hasOptionalResult(Impl::Location location, string element, string tag, string value); |
There was a problem hiding this comment.
This could have a default none() implementation.
There was a problem hiding this comment.
Can we do that now? Note that this predicate refers to part of the signature: Impl::Location.
There was a problem hiding this comment.
I see we have an internal PR open that'll likely help here. We should probably hold this off until that has landed in a release.
There was a problem hiding this comment.
Ah yes, you are right, we can't do that just yet.
There was a problem hiding this comment.
@hvitved none() implementation added. I assume we still need to wait with this PR until support for referencing other parts of the module signature in defaults is available in a release (which it isn't yet, should be 2.13.4)?
There was a problem hiding this comment.
I just doubled checked and it seems that the default here was not working for some other reason when I last tried this. Testing this with CodeQL 2.13.1 the default for this seems to work out-of-the-box.
There was a problem hiding this comment.
The Compile all queries using the latest stable CodeQL CLI check should be enough to ensure that it works with the latest release.
| @@ -0,0 +1,2 @@ | |||
| failures | |||
There was a problem hiding this comment.
It's a bit of a shame that we also have the failures predicate here, but I don't see an easy way to avoid that. Should of course disappear when we have converted all existing tests away from the legacy interface.
There was a problem hiding this comment.
I completely agree.
No description provided.