JS: Allow NonKeyCiphers to include truncated SHA-512 MDs in Forge JS libr… #12825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
changed the title
asgerf
requested changes
Apr 14, 2023
javascript/ql/lib/change-notes/2023-04-13-Forge-truncated-sha512-hash
Outdated
Show resolved
Hide resolved
|
There is also a format issue in You can run the auto-formatter either in VSCode (ctrl+shift+p: format document), |
…12-hash Co-authored-by: Asger F <asgerf@github.com>
asgerf
approved these changes
May 2, 2023
|
Thanks for the contribution @smiddy007! Sorry it took this long to get it merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Forge module in
CryptoLibraries.qllnow correctly classifies SHA-512/224, SHA-512/256, and SHA-512/384 hashes used in message digests as NonKeyCiphers.Purpose was to match the following code in InsufficientPasswordHash.ql
var hasher = forge.md.sha512.sha256.create();
var hashed = hasher.update(password); // BAD
However, SHA512224, SHA512256, AND SHA512384 are not include in the CryptoAlgorithmNames.qll file. Something else may need to be updated so that the algorithm reflected in message digest is the truncated hash, instead of just SHA512.