Skip to content

Swift: add QLdoc for generated Raw and Synth modules #12842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2023
Merged

Swift: add QLdoc for generated Raw and Synth modules #12842

merged 1 commit into from
Apr 17, 2023

Conversation

redsun82
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Swift label Apr 17, 2023
@redsun82 redsun82 force-pushed the redsun82/swift-qlgen-qldoc branch from f15116d to edb355b Compare April 17, 2023 07:38
@redsun82 redsun82 marked this pull request as ready for review April 17, 2023 07:38
@redsun82 redsun82 requested a review from a team as a code owner April 17, 2023 07:38
@redsun82 redsun82 requested a review from MathiasVP April 17, 2023 07:39
MathiasVP
MathiasVP approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Obviously, for the sanity of future people working on the raw and synth layers, we should add better comments eventually. But since this is meant to be interacted with by a very small number of people I think this is good enough for now :)

@redsun82 redsun82 merged commit fdd975b into main Apr 17, 2023
@redsun82 redsun82 deleted the redsun82/swift-qlgen-qldoc branch April 17, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redsun82 @MathiasVP