Swift: Delete deprecated classes #12877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The QLDoc test failures appear to just be the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete deprecated classes in Swift, before the public beta. After public beta we will have a short (1 release) deprecation cycle, after general release we will have the full (1 year) deprecation cycle. It seems best to start from a clean state.
This excludes files shared with other languages (these things will follow the normal deprecation cycle in sync with other languages) and
BarrierGuardinDataFlowPublic.qll(coupled to the above).I've also renamed a couple of dataflow modules for different queries that had ended up with the same names - not ideal if someone ever wants to use them together for whatever reason.