Python: Hide ModuleVariableNode in data-flow paths
#12937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases mod.getName() does not have a result, so toString of ModuleVariableNode would also not have a result, which would cause data-flow paths that use these as an edge to not be valid :O
They just add an extra step, and don't actually contribute any good information for end-users.
yoff
reviewed
May 2, 2023
With the way our tests are set up, I don't think we used to miss any paths in our tests (only when files were extracted as script). |
|
(but agreed it would have been cleaner to accept test changes for each commit individually) |
In that case, it would make no difference.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They just add an extra step, and don't actually contribute any good information for end-users.
(also fixed their .toString() implementation)
This will generate a lot of changes in .expected files, which I will fix up once tests have indicated which ones :D