Update links to CodeQL manual in the codeql.github.com site #12967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make CodeQL CLI a single item in the side navigation
aeisenberg
reviewed
Apr 28, 2023
| @@ -4,15 +4,15 @@ | |||
| <https://docs.github.com/en/code-security/codeql-cli/using-the-codeql-cli/using-custom-queries-with-the-codeql-cli#including-query-metadata>`__. You can also execute queries using the following | |||
There was a problem hiding this comment.
Is this file still being used? I can't find any references to it in github/codeql.
| @@ -4,15 +4,15 @@ | |||
| <https://docs.github.com/en/code-security/codeql-cli/using-the-codeql-cli/using-custom-queries-with-the-codeql-cli#including-query-metadata>`__. You can also execute queries using the following | |||
| plumbing-level subcommands: | |||
|
|
|||
| - `database run-queries <../manual/database-run-queries>`__, which | |||
| - `database run-queries <https://docs.github.com/en/code-security/codeql-cli/codeql-cli-manual/database-run-queries>`__, which | |||
| outputs non-interpreted results in an intermediate binary format called | |||
| :ref:`BQRS <bqrs-file>`. | |||
There was a problem hiding this comment.
Is this ref correct? I'm not sure how rst resolves this.
There was a problem hiding this comment.
There was a problem hiding this comment.
I think it's correct. It's modelled on the link in line 4. However, if the file isn't being used any more, it sounds as if it might be better to delete it.
Having checked, it was used in a CodeQL CLI article that's now moved to docs.github.com.
aeisenberg
approved these changes
Apr 28, 2023
| @@ -4,15 +4,15 @@ | |||
| <https://docs.github.com/en/code-security/codeql-cli/using-the-codeql-cli/using-custom-queries-with-the-codeql-cli#including-query-metadata>`__. You can also execute queries using the following | |||
| plumbing-level subcommands: | |||
|
|
|||
| - `database run-queries <../manual/database-run-queries>`__, which | |||
| - `database run-queries <https://docs.github.com/en/code-security/codeql-cli/codeql-cli-manual/database-run-queries>`__, which | |||
| outputs non-interpreted results in an intermediate binary format called | |||
| :ref:`BQRS <bqrs-file>`. | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to updating some links, this will also make CodeQL CLI a single, unexpandable item in the side navigation.
This is follow-up work after the migration of the CodeQL CLI manual to CodeQL CLI commands manual. We're also adding redirects from the old articles to the location separately.