Skip to content

C++: Make implicit this receivers explicit #12999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023

Conversation

kaspersv
Copy link
Contributor

@kaspersv kaspersv commented May 3, 2023

Make all implicit this call receivers explicit to align with internal style guidelines.

Automatically generated from results of QL-for-QL implicit this query as follows:

$CODEQL database create $LANG-db -l ql -s $CODEQL_PATH/$LANG/ql --search-path $CODEQL_PATH/ql/extractor-pack
$CODEQL database analyze $LANG-db --format=csv --output=$LANG $CODEQL_PATH/ql/ql/src/queries/style/ImplicitThis.ql
python3 insert-explicit-this.py $LANG $CODEQL_PATH/$LANG/ql $CODEQL

using the insert-explicit-this.py script to interpret the results and insert explicit this receivers.

@github-actions github-actions bot added the C++ label May 3, 2023
@kaspersv kaspersv force-pushed the kaspersv/cpp-explicit-this-receiver branch from bd0b85b to 8f3db08 Compare May 3, 2023 08:21
@kaspersv kaspersv force-pushed the kaspersv/cpp-explicit-this-receiver branch from 8f3db08 to c9fba18 Compare May 3, 2023 08:31
@kaspersv kaspersv added the no-change-note-required This PR does not need a change note label May 3, 2023
@kaspersv kaspersv marked this pull request as ready for review May 3, 2023 09:29
@kaspersv kaspersv requested a review from a team as a code owner May 3, 2023 09:29
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaspersv kaspersv merged commit be08b97 into github:main May 3, 2023
@kaspersv kaspersv deleted the kaspersv/cpp-explicit-this-receiver branch June 20, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants