Skip to content

Python: Enable implicit this warnings #13026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kaspersv
Copy link
Contributor

@kaspersv kaspersv commented May 4, 2023

Enable warnings for member predicate calls with implicit this receivers for Python to prevent them from reappearing.

@kaspersv kaspersv added the no-change-note-required This PR does not need a change note label May 4, 2023
@github-actions github-actions bot added the Python label May 4, 2023
@kaspersv kaspersv force-pushed the kaspersv/python-enable-warn-on-implicit-this branch from 41c3c0f to 5c6d37e Compare May 4, 2023 07:44
@kaspersv kaspersv force-pushed the kaspersv/python-enable-warn-on-implicit-this branch from 5c6d37e to d9f29a8 Compare May 4, 2023 08:17
@kaspersv kaspersv marked this pull request as ready for review May 4, 2023 09:03
@kaspersv kaspersv requested a review from a team as a code owner May 4, 2023 09:03
@RasmusWL RasmusWL added no-change-note-required This PR does not need a change note and removed no-change-note-required This PR does not need a change note labels May 4, 2023
@kaspersv kaspersv merged commit f2031e4 into github:main May 4, 2023
@RasmusWL
Copy link
Member

RasmusWL commented May 4, 2023

(I had a small window of time where I thought a change-note would be required, but then realized this only affects codeql development, not people who depend on our libraries)

@kaspersv kaspersv deleted the kaspersv/python-enable-warn-on-implicit-this branch June 20, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants