Skip to content

Go: Downgrade go/autobuilder/package-not-found diagnostic to warning #13038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2023
Merged

Go: Downgrade go/autobuilder/package-not-found diagnostic to warning #13038

merged 1 commit into from
May 10, 2023

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented May 4, 2023

error is reserved for when the build fails.

@owen-mc owen-mc requested a review from a team as a code owner May 4, 2023 13:57
@github-actions github-actions bot added the Go label May 4, 2023
mbg
mbg approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. One thing to check before merging this is with the TSP team whether changing the severity of a diagnostic causes any problems for them.

@owen-mc
Downgrade package-not-found diagnostic to warning
f9d2467 
error is reserved for when the build fails.
@owen-mc owen-mc force-pushed the go/downgrade-package-not-found-diagnostic-to-warning branch from 54c2ee8 to f9d2467 Compare May 10, 2023 08:59
henrymercer
henrymercer approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! One further tweak might be explicitly describing the impact of the packages not being found in the error message, e.g. saying that some files may not be fully analyzed.

@owen-mc owen-mc merged commit edeffd8 into github:main May 10, 2023
@owen-mc owen-mc deleted the go/downgrade-package-not-found-diagnostic-to-warning branch May 10, 2023 10:24
@owen-mc
Copy link
Contributor Author

owen-mc commented May 10, 2023

Good suggestion @henrymercer . I will consider that in a follow-up PR, as I want to get this change merged and into a released version sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbg mbg mbg approved these changes

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owen-mc @mbg @henrymercer