Skip to content

Ruby: Add Sequel as SQL Injection Sink #13066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

maikypedia
Copy link
Contributor

This pull request adds sequel library Sinks for SQL Injection. The list of methods that accept raw SQL statements is incomplete, but I haven't included several methods because they are internal. Here is the list in case it is convenient to add them as a sink :

"aliased_expression_sql_append", "array_sql_append", "boolean_constant_sql_append", "case_expression_sql_append", "cast_sql_append", "column_all_sql_append", "complex_expression_sql_append", "constant_sql_append", "delayed_evaluation_sql_append", "function_sql_append", "join_clause_sql_append", "join_using_clause_sql_append", "literal_append", "negative_boolean_constant_sql_append", "ordered_expression_sql_append", "placeholder_literal_string_sql_append", "qualified_identifier_sql_append", "quote_identifier_append", "quote_schema_table_append", "quoted_identifier_append", "subscript_sql_append", "window_sql_append"

Looking forward to your suggestions.

Copy link
Contributor

@alexrford alexrford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I checked against https://github.com/jeremyevans/sequel/blob/master/doc/security.rdoc and I'm happy with the coverage here. Haven't been able to run performance tests yet, but I'll update when I'm able to do that.

alexrford
alexrford previously approved these changes May 31, 2023
Copy link
Contributor

@alexrford alexrford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance looks good. There's a merge conflict in Frameworks.qll now - I can re-approve and merge once this is resolved.

@alexrford alexrford merged commit 40cf099 into github:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants