Skip to content

C++: Make implicit this receivers explicit #13084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kaspersv
Copy link
Contributor

@kaspersv kaspersv commented May 9, 2023

Make implicit this call receivers explicit to align with internal style guidelines.

Validated that the compiled DIL for the upgrade script is preserved by the change.

@kaspersv kaspersv added the no-change-note-required This PR does not need a change note label May 9, 2023
@github-actions github-actions bot added the C++ label May 9, 2023
@kaspersv kaspersv force-pushed the kaspersv/cpp-explicit-this-receivers2 branch from 4996d38 to 14a2bf8 Compare May 9, 2023 13:31
@kaspersv kaspersv changed the title C++: Enable implicit this receiver warnings C++: Make implicit this receivers explicit May 9, 2023
@kaspersv kaspersv force-pushed the kaspersv/cpp-explicit-this-receivers2 branch from 14a2bf8 to 5b45962 Compare May 10, 2023 10:34
@kaspersv kaspersv marked this pull request as ready for review May 10, 2023 13:05
@kaspersv kaspersv requested a review from a team as a code owner May 10, 2023 13:05
@kaspersv kaspersv merged commit c2a3f37 into github:main May 10, 2023
@kaspersv kaspersv deleted the kaspersv/cpp-explicit-this-receivers2 branch June 20, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants