Skip to content

Java: Add constraint to HostnameSanitizingPrefix to prevent false negatives in SSRF queries #13097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

egregius313
Copy link
Contributor

Adds a check to make sure the sanitizing prefix is not the second / in the :// of a protocol specifier.

@egregius313 egregius313 added the no-change-note-required This PR does not need a change note label May 10, 2023
@github-actions github-actions bot added the Java label May 10, 2023
@egregius313 egregius313 marked this pull request as ready for review May 12, 2023 21:53
@egregius313 egregius313 requested a review from a team as a code owner May 12, 2023 21:53
@egregius313 egregius313 force-pushed the egregius313/java/webgoat/ssrf-regex-fix branch 2 times, most recently from a80b0a8 to 8ce9ed7 Compare May 15, 2023 15:38
@atorralba
Copy link
Contributor

This has impact on users, so it will need a change note.

@egregius313 egregius313 removed the no-change-note-required This PR does not need a change note label May 16, 2023
@egregius313 egregius313 force-pushed the egregius313/java/webgoat/ssrf-regex-fix branch from c60737e to 2d69f81 Compare May 22, 2023 19:57
@egregius313 egregius313 merged commit 5234080 into github:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants