Skip to content

Swift: Enable implicit this receiver warnings #13120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2023
Merged

Swift: Enable implicit this receiver warnings #13120

merged 1 commit into from
May 11, 2023

Conversation

kaspersv
Copy link
Contributor

@kaspersv kaspersv commented May 11, 2023 •
edited
Loading

Enable warnings for member predicate calls with implicit this receivers for Swift to prevent them from reappearing.

@kaspersv kaspersv added the no-change-note-required This PR does not need a change note label May 11, 2023
@github-actions github-actions bot added the Swift label May 11, 2023
@kaspersv kaspersv marked this pull request as ready for review May 11, 2023 07:28
@kaspersv kaspersv requested a review from a team as a code owner May 11, 2023 07:28
jketema
jketema approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaspersv kaspersv merged commit 0df1e7c into github:main May 11, 2023
@kaspersv kaspersv deleted the kaspersv/swift-implicit-this-warnings branch June 20, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jketema jketema jketema approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaspersv @jketema