Skip to content

Go: fix unit test #13135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2023
Merged

Go: fix unit test #13135

merged 3 commits into from
May 16, 2023
+27 −35

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented May 11, 2023

No description provided.

@owen-mc owen-mc requested a review from a team as a code owner May 11, 2023 16:12
@github-actions github-actions bot added the Go label May 11, 2023
@owen-mc owen-mc mentioned this pull request May 11, 2023
Closed
@owen-mc
Do not obscure exit code with call to grep
77c8357 
The output is a bit more verbose, but this is hard to avoid
mbg
mbg approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@mbg mbg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that tests actually pass in the CI run (prior to the change made in 77c8357).

smowton
smowton approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general note that set -o pipefail gives the behaviour you want, but in this case there doesn't seem to be a lot of output to mask, so the simple solution is fine.

@owen-mc owen-mc merged commit 1a9bd9c into github:main May 16, 2023
@owen-mc owen-mc deleted the go/fix-unit-test branch May 16, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbg mbg mbg approved these changes

@smowton smowton smowton approved these changes

Assignees
No one assigned
Labels
Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owen-mc @mbg @smowton