C++: Block flow through back-edges in cpp/overrun-write
#13149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
approved these changes
May 15, 2023
|
Two lost results. Both of which are FPs due to an unbounded loop in the second projection of the product-flow graph that continuously increment the state. As an extra bonus: Surprisingly, this PR fixes the performance problem on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a class of false positives involving flow through back edges for the
cpp/overrun-writequery. The fix is identical to the one applied to thecpp/invalid-pointer-derefin this PR.Keeping this as a draft until I can run it on DCA.