Enable implicit this warnings for shared packs #13173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
reviewed
May 16, 2023
shared/ssa/qlpack.yml
Outdated
| @@ -1,4 +1,5 @@ | |||
| name: codeql/ssa | |||
| version: 0.0.17-dev | |||
| groups: shared | |||
| warnOnImplicitThis: true | |||
There was a problem hiding this comment.
Could we be a little more consistent with the ordering of the lines in these files? In some of these you add the line before library: true and in some you add it after. And for the language packs, I think you've added these lines after dependencies, so maybe do that as well here (depending on whether the ordering in the language packs are consistent - I haven't checked).
There was a problem hiding this comment.
The ordering in language packs is not consistent, not even within each language. For language packs I added the warnOnImplicitThis option as the last line. I've updated this PR to add the option as the last line as well.
kaspersv
force-pushed
the
kaspersv/enable-implicit-this-warnings-shared-packs
branch
from
ef3369f to
bea3779
Compare
kaspersv
force-pushed
the
kaspersv/enable-implicit-this-warnings-shared-packs
branch
from
bea3779 to
bfb098c
Compare
aschackmull
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable implicit this warnings for shared QL packs