Skip to content

C++: Add forgotten private specifiers in product flow #13199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2023
Merged

C++: Add forgotten private specifiers in product flow #13199

merged 1 commit into from
May 17, 2023

Conversation

jketema
Copy link
Contributor

@jketema jketema commented May 17, 2023

Note that Config1 was already marked as private.

@jketema jketema requested a review from a team as a code owner May 17, 2023 09:26
@github-actions github-actions bot added the C++ label May 17, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems May 17, 2023
View reviewed changes
cpp/ql/lib/experimental/semmle/code/cpp/dataflow/ProductFlow.qll

module Config2 implements DataFlow::StateConfigSig {
private module Config2 implements DataFlow::StateConfigSig {

Check warning

Code scanning / CodeQL

Data flow configuration module naming

Modules implementing a data flow configuration should end in `Config`.
@jketema jketema merged commit 8ad1159 into github:main May 17, 2023
@jketema jketema deleted the private-prod-flow branch May 17, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @MathiasVP