Skip to content

Swift: remove unneeded properties from InterpolatedStringLiteralExpr #13238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2023
Merged

Swift: remove unneeded properties from InterpolatedStringLiteralExpr #13238

merged 4 commits into from
May 23, 2023

Conversation

redsun82
Copy link
Contributor

These properties were unused in the QL library (hence the full upgrade/downgrade compatibility).

@redsun82 redsun82 requested a review from geoffw0 May 22, 2023 13:21
@redsun82 redsun82 requested a review from a team as a code owner May 22, 2023 13:21
@github-actions github-actions bot added the Swift label May 22, 2023
@redsun82
Swift: remove unneeded properties from InterpolatedStringLiteralExpr
9a0f874 
These properties were unused in the QL library (hence the full
upgrade/downgrade compatibility).
@redsun82 redsun82 force-pushed the redsun82/swift-remove-props-from-interpolated-strings branch from 84d751d to 9a0f874 Compare May 22, 2023 13:29
MathiasVP
MathiasVP previously approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

geoffw0
geoffw0 reviewed May 22, 2023
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions, but LGTM.

@redsun82 redsun82 self-assigned this May 23, 2023
@aibaars aibaars changed the base branch from main to codeql-cli-2.13.2 May 23, 2023 10:45
@aibaars aibaars requested review from a team as code owners May 23, 2023 10:45
@aibaars aibaars changed the base branch from codeql-cli-2.13.2 to main May 23, 2023 10:46
@redsun82 redsun82 changed the base branch from main to codeql-cli-2.13.3 May 23, 2023 10:46
@redsun82
Copy link
Contributor Author

DCA looks good as far as I'm concerned, this can be merged as soon as CI is happy.

@redsun82 redsun82 removed request for a team May 23, 2023 10:56
@redsun82 redsun82 requested review from a team and removed request for a team May 23, 2023 10:56
@redsun82 redsun82 requested a review from geoffw0 May 23, 2023 12:42
geoffw0
geoffw0 approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@redsun82 redsun82 merged commit a14f7dd into codeql-cli-2.13.3 May 23, 2023
@redsun82 redsun82 deleted the redsun82/swift-remove-props-from-interpolated-strings branch May 23, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP left review comments

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees

@redsun82 redsun82

Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redsun82 @MathiasVP @geoffw0