C++: Promote the product-dataflow library out of experimental #13244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
force-pushed
the
promote-product-flow
branch
from
1cf20f9 to
3b893db
Compare
hvitved
reviewed
May 23, 2023
| @@ -1,10 +1,29 @@ | |||
| import semmle.code.cpp.ir.dataflow.DataFlow | |||
| /** | |||
There was a problem hiding this comment.
How about putting it in dataflow/internal, for now? Eventually, this should probably be in the shared dataflow pack?
There was a problem hiding this comment.
We could definitely do that, yeah 👍. I guess that means I should also revert the change note commit since we don't want users importing internal libraries.
There was a problem hiding this comment.
I've force-pushed a new commit that moves the library to dataflow/internal now. I've also reverted the change note since we don't want people to start using the library yet now that it's in an internal folder.
MathiasVP
force-pushed
the
promote-product-flow
branch
from
3b893db to
81dbfec
Compare
rdmarsh2
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the experimental product-dataflow library out of the experimental directory. This is a necessary step before we can promote any of the new experimental queries that depend on it out of experimental.
I'm happy to bikeshed on the QLDoc I've added if you can think of something that sounds better 😅.