Skip to content

C++: Rewrite flow test common to use inline expectation test module #13260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023

Conversation

jketema
Copy link
Contributor

@jketema jketema commented May 23, 2023

This also rewrites all uses of flow test common to use DataFlow::ConfigSig.

Note that the removed deprecated aliases are 14 months old by now and, hence, can be safely removed.

@jketema jketema requested a review from a team as a code owner May 23, 2023 14:31
@github-actions github-actions bot added the C++ label May 23, 2023
This also rewrites all uses of flow test common to use `DataFlow::ConfigSig`.

Note that the removed deprecated aliases are 14 months old by now and, hence,
can be safely removed.
@jketema jketema force-pushed the test-config-sig branch from 22669b4 to aeb6293 Compare May 23, 2023 14:34
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MathiasVP MathiasVP merged commit 6fca8df into github:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants