C#: Re-factor getComponent. #13262
Merged
C#: Re-factor getComponent. #13262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
michaelnebel
force-pushed
the
flowsummary/refactorgetcomponentstack
branch
4 times, most recently
from
2b53a37 to
a6dec6f
Compare
|
@hvitved: Would you mind review'ing this PR before all other teams get notified (this is only a minor change). |
hvitved
reviewed
May 25, 2023
michaelnebel
force-pushed
the
flowsummary/refactorgetcomponentstack
branch
from
a6dec6f to
915042a
Compare
hvitved
approved these changes
May 30, 2023
michaelnebel
added
the
no-change-note-required
|
DCA looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a pre-requisite for #13147 to avoid non monotonic recursion (basically we need to eliminate the negation in getComponent).