C++: Exclude StdNamespace sources in cpp/constant-size-array-off-by-one
#13318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is causing a lot of FPs. Let's exclude this for now to reduce the number of results for this query.
jketema
approved these changes
May 30, 2023
|
DCA looks good. We lose a couple of results, and these are the ones we expected to lose (i.e., results in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various containers in the standard library apply the small string optimization, and we can't currently reason about the path conditions that makes it clear that these accesses are safe. So for now we decided to just exclude them from the query to reduce the number of results.