Skip to content

Swift: Fix some C++20 todos. #13336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2023
Merged

Swift: Fix some C++20 todos. #13336

merged 3 commits into from
Jun 13, 2023

Conversation

sashabu
Copy link
Contributor

@sashabu sashabu commented May 31, 2023

No description provided.

@github-actions github-actions bot added the Swift label May 31, 2023
@sashabu sashabu changed the base branch from sashabu/c++20 to main May 31, 2023 18:35
@sashabu sashabu force-pushed the sashabu/c++20-todos branch 2 times, most recently from f118c69 to 9a4496c Compare May 31, 2023 18:55
@sashabu sashabu changed the base branch from main to sashabu/c++20 May 31, 2023 18:55
@sashabu sashabu marked this pull request as ready for review June 1, 2023 11:05
@sashabu sashabu requested a review from a team as a code owner June 1, 2023 11:05
@sashabu sashabu requested a review from a team as a code owner June 1, 2023 12:13
@sashabu sashabu force-pushed the sashabu/c++20-todos branch from 9a4496c to 99d640e Compare June 1, 2023 12:14
@sashabu sashabu force-pushed the sashabu/c++20-todos branch from 99d640e to 928c170 Compare June 6, 2023 14:22
geoffw0
geoffw0 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@sashabu sashabu force-pushed the sashabu/c++20-todos branch from 928c170 to f66c675 Compare June 8, 2023 11:53
@sashabu sashabu force-pushed the sashabu/c++20-todos branch from f66c675 to 790bcec Compare June 8, 2023 12:11
@sashabu sashabu force-pushed the sashabu/c++20-todos branch from 790bcec to 9ec0900 Compare June 8, 2023 13:55
geoffw0
geoffw0 previously approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, happy for this to be merged when we are ready.

Base automatically changed from sashabu/c++20 to main June 13, 2023 14:03
@sashabu sashabu dismissed geoffw0’s stale review June 13, 2023 14:03

The base branch was changed.

@sashabu sashabu requested a review from geoffw0 June 13, 2023 14:24
@sashabu sashabu merged commit 7280f07 into main Jun 13, 2023
@sashabu sashabu deleted the sashabu/c++20-todos branch June 13, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sashabu @geoffw0