Skip to content

JS: stop recursive fromRhs related to getLaterBaseAccess #13349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2023
Merged

JS: stop recursive fromRhs related to getLaterBaseAccess #13349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eed1a9
stop recursive fromRhs related to getLaterBaseAccess
erik-krogh Jun 1, 2023
1b44b59
add stress test
erik-krogh Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,8 @@ module AccessPath {
or
baseName = fromRhs(write.getBase(), root)
or
baseName = fromRhs(GetLaterAccess::getLaterBaseAccess(write), root)
baseName = fromRhs(GetLaterAccess::getLaterBaseAccess(write), root) and
not baseName.matches("%.%")
)
or
exists(GlobalVariable var |
Expand Down
33 changes: 33 additions & 0 deletions javascript/ql/test/library-tests/GlobalAccessPaths/stress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@

// stress test for global access path computation
var MyObject = {}
MyObject.Foo1 = { inner: MyObject };
MyObject.Foo2 = { inner: MyObject };
MyObject.Foo3 = { inner: MyObject };
MyObject.Foo4 = { inner: MyObject };
MyObject.Foo5 = { inner: MyObject };
MyObject.Foo6 = { inner: MyObject };
MyObject.Foo7 = { inner: MyObject };
MyObject.Foo8 = { inner: MyObject };
MyObject.Foo9 = { inner: MyObject };
MyObject.Fooa = { inner: MyObject };
MyObject.Foob = { inner: MyObject };
MyObject.Fooc = { inner: MyObject };
MyObject.Food = { inner: MyObject };
MyObject.Fooe = { inner: MyObject };
MyObject.Foof = { inner: MyObject };
MyObject.Foog = { inner: MyObject };
MyObject.Fooh = { inner: MyObject };
MyObject.Fooi = { inner: MyObject };
MyObject.Fooj = { inner: MyObject };
MyObject.Fook = { inner: MyObject };
MyObject.Fool = { inner: MyObject };
MyObject.Foom = { inner: MyObject };
MyObject.Foon = { inner: MyObject };
MyObject.Fooo = { inner: MyObject };
MyObject.Foop = { inner: MyObject };
MyObject.Fooq = { inner: MyObject };
MyObject.Foor = { inner: MyObject };
MyObject.Foos = { inner: MyObject };
MyObject.Foot = { inner: MyObject };
exports.MyObject = MyObject;