Skip to content

Ruby: fix bug in filter_map summary #13422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Ruby: fix bug in filter_map summary #13422

merged 3 commits into from
Jun 13, 2023

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Jun 9, 2023

The previous summary would propagate values directly to the output as if the callback was the identity function. Now it behaves like the summary for map, where the return value is based on the return value of the block.

@github-actions github-actions bot added the Ruby label Jun 9, 2023
@asgerf asgerf marked this pull request as ready for review June 12, 2023 08:07
@asgerf asgerf requested a review from a team as a code owner June 12, 2023 08:07
@calumgrant calumgrant requested a review from alexrford June 12, 2023 08:36
@asgerf asgerf merged commit 0d45074 into github:main Jun 13, 2023
---
category: minorAnalysis
---
* Fixed a bug in how `map_filter` calls are analyzed. Previously, such calls would
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/map_filter/filter_map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants