Re-factor printing of summary component stacks. #13452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
refactorstackprinting
branch
from
f4c3fcd to
3f06055
Compare
michaelnebel
force-pushed
the
refactorstackprinting
branch
3 times, most recently
from
3fba6d1 to
87a8117
Compare
michaelnebel
changed the title
hvitved
reviewed
Jun 21, 2023
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
hvitved
requested changes
Jun 22, 2023
python/ql/lib/semmle/python/dataflow/new/internal/FlowSummaryImplSpecific.qll
Show resolved
Hide resolved
ruby/ql/lib/codeql/ruby/dataflow/internal/FlowSummaryImplSpecific.qll
Outdated
Show resolved
Hide resolved
ruby/ql/lib/codeql/ruby/dataflow/internal/FlowSummaryImplSpecific.qll
Outdated
Show resolved
Hide resolved
swift/ql/test/query-tests/Security/CWE-089/SqlInjection.expected
Outdated
Show resolved
Hide resolved
michaelnebel
force-pushed
the
refactorstackprinting
branch
from
ac77e0c to
40e8d33
Compare
michaelnebel
added
the
no-change-note-required
hvitved
previously approved these changes
Jun 22, 2023
michaelnebel
force-pushed
the
refactorstackprinting
branch
from
40e8d33 to
299481c
Compare
|
DCA looks good. |
yoff
reviewed
Jun 23, 2023
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImplSpecific.qll
Outdated
Show resolved
Hide resolved
python/ql/lib/semmle/python/dataflow/new/internal/FlowSummaryImplSpecific.qll
Show resolved
Hide resolved
hvitved
previously approved these changes
Jun 23, 2023
…y component stacks.
michaelnebel
force-pushed
the
refactorstackprinting
branch
from
7c3bae1 to
7a5dd8d
Compare
michaelnebel
force-pushed
the
refactorstackprinting
branch
from
7a5dd8d to
243c592
Compare
|
@hvitved : Only change since your last review is the last commit. |
hvitved
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we try to align then printing of summary component stacks with their textual representation as they would like, when being used in an access path (for MaD models).
Furthermore, it turns out that the existing printer
getComponentStackis not up to date for all languages. This is also fixed in this PR.