Skip to content

Java: clean up mad kinds use #13480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2023
Merged

Java: clean up mad kinds use #13480

merged 2 commits into from
Jun 19, 2023

Conversation

jhelie
Copy link
Contributor

@jhelie jhelie commented Jun 16, 2023 •
edited
Loading

This PR refactors code relevant to automodel to only use the native mad kinds.

I wonder: should we put in test for the existing queries with .expected files for the extraction queries?

@github-actions github-actions bot added the Java label Jun 16, 2023
@jhelie jhelie marked this pull request as ready for review June 16, 2023 13:49
@jhelie jhelie requested a review from a team as a code owner June 16, 2023 13:49
@jhelie jhelie requested review from tausbn and adityasharad June 16, 2023 13:49
@jhelie jhelie added the no-change-note-required This PR does not need a change note label Jun 16, 2023
@owen-mc owen-mc changed the title clean up mad kinds use Java: clean up mad kinds use Jun 16, 2023
adityasharad
adityasharad approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. I think we can do tests and consistency queries (checking that all kinds are valid) as a follow up.

tausbn
tausbn approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@jhelie jhelie merged commit 4233363 into main Jun 19, 2023
@jhelie jhelie deleted the jhelie/clean-up-mad-kinds-use branch June 19, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tausbn tausbn tausbn approved these changes

@adityasharad adityasharad adityasharad approved these changes

+1 more reviewer

@atorralba atorralba atorralba approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhelie @tausbn @adityasharad @atorralba