Skip to content

Shared: use final class aliases to use extends instead of instanceof in the shared libraries #13488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2023
Merged

Shared: use final class aliases to use extends instead of instanceof in the shared libraries #13488

merged 1 commit into from
Sep 18, 2023

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jun 17, 2023 •
edited
Loading

This allows the implementation to inherit the implementations from the super class, instead of having to insert predicates like:

string toString() { result = super.toString() }

@erik-krogh erik-krogh requested a review from aibaars September 18, 2023 08:36
@erik-krogh erik-krogh marked this pull request as ready for review September 18, 2023 08:36
aschackmull
aschackmull approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erik-krogh erik-krogh merged commit 998237e into github:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

@aibaars aibaars Awaiting requested review from aibaars

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erik-krogh @aschackmull