Skip to content

QL: Exclude overridden fields from FieldOnlyUsedInCharPred.ql #13517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2023
Merged

QL: Exclude overridden fields from FieldOnlyUsedInCharPred.ql #13517

merged 2 commits into from
Jun 20, 2023

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jun 20, 2023 •
edited
Loading

FP spotted on #13509.

@hvitved hvitved marked this pull request as ready for review June 20, 2023 13:51
@hvitved hvitved requested a review from a team as a code owner June 20, 2023 13:51
@owen-mc
Copy link
Contributor

owen-mc commented Jun 20, 2023

I think this will also fix some false positives in the Go library.

@MathiasVP MathiasVP merged commit 865c050 into github:main Jun 20, 2023
@MathiasVP
Copy link
Contributor

:shipit:!

@hvitved hvitved deleted the ql/field-only-used-in-charpred-fix branch June 20, 2023 17:28
@hvitved hvitved mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-krogh erik-krogh erik-krogh approved these changes

Assignees
No one assigned
Labels
QL-for-QL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hvitved @owen-mc @MathiasVP @erik-krogh