Ruby: add rack env['QUERY_STRING'] as a remote flow input
#13585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrford
added
no-change-note-required
alexrford
force-pushed
the
rb/rack-env-query-string
branch
from
9caf060 to
9b2cd76
Compare
alexrford
force-pushed
the
rb/rack-env-query-string
branch
from
42406a5 to
08784d2
Compare
asgerf
previously approved these changes
Jul 14, 2023
Co-authored-by: Asger F <asgerf@github.com>
alexrford
removed
the
no-change-note-required
aibaars
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env['QUERY_STRING']gives direct access to the request query string, which can be user controlled.This will conflict trivially with #13566 due to test changes.