Skip to content

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jun 27, 2023

No description provided.

@github-actions github-actions bot added the C++ label Jun 27, 2023
@jketema jketema force-pushed the pointer-deref-barrier branch from b93d213 to 14609a9 Compare June 28, 2023 12:05
@jketema
Copy link
Contributor Author

jketema commented Jun 28, 2023

DCA alert changes from the first DCA experiment are as expected, removing FP alerts that we expect this PR to remove.

@jketema jketema marked this pull request as ready for review June 28, 2023 12:44
@jketema jketema requested a review from a team as a code owner June 28, 2023 12:44
@MathiasVP
Copy link
Contributor

This FP also disappeared, right?:

void test26(unsigned size) {
  char *xs = new char[size];
  char *p = xs;
  char *end = p + size;
  if (p + 4 <= end) {
    p += 4;
  }
  if (p < end) {
    int val = *p; // GOOD [FALSE POSITIVE]
  }
}

@jketema
Copy link
Contributor Author

jketema commented Jun 28, 2023

This FP also disappeared, right?:

Yes. I apparently forgot to completely update the test file. Thanks for spotting that.

Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once DCA is happy! (and the annotation has been fixed)

@jketema jketema merged commit 43a8119 into github:main Jun 28, 2023
@jketema jketema deleted the pointer-deref-barrier branch June 28, 2023 15:46
@jketema
Copy link
Contributor Author

jketema commented Jun 28, 2023

This FP also disappeared, right?:

Yes. I apparently forgot to completely update the test file. Thanks for spotting that.

Fixed in #13604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants