Skip to content

Conversation

jorgectf
Copy link
Contributor

This PR adds models for javax.portlet 2.0.

MRVA across top 1k

@jorgectf jorgectf requested a review from a team as a code owner June 28, 2023 15:55
@github-actions
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java extensions,"``javax.*``, ``jakarta.*``",63,611,34,2,4,,1,1,2
+    Java extensions,"``javax.*``, ``jakarta.*``",63,672,34,2,4,,1,1,2
-    Totals,,283,13532,2059,286,16,122,33,1,390
+    Totals,,283,13593,2059,286,16,122,33,1,390
  • Changes to framework-coverage-java.csv:
+ javax.portlet,,,61,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,61,

Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't generate alert diffs in projects among the top 1k that use javax.portlet, so it should be safe to marge.

@atorralba atorralba merged commit 1f4af5f into github:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants