Skip to content

document final extensions in the language specification #13633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2023
Merged

document final extensions in the language specification #13633

merged 2 commits into from
Jul 5, 2023

Conversation

ginsbach
Copy link
Contributor

@ginsbach ginsbach commented Jun 30, 2023 •
edited
Loading

@ginsbach ginsbach mentioned this pull request Jun 30, 2023
Merged
@ginsbach ginsbach force-pushed the ginsbach/SpecifyExtendsFinal branch from 23343f5 to c5e2b32 Compare June 30, 2023 11:21
@ginsbach ginsbach force-pushed the ginsbach/SpecifyExtendsFinal branch from c5e2b32 to 9ccbe73 Compare June 30, 2023 11:39
@ginsbach ginsbach marked this pull request as ready for review June 30, 2023 11:53
@ginsbach ginsbach requested a review from a team as a code owner June 30, 2023 11:53
@ginsbach ginsbach requested a review from alexet June 30, 2023 11:53
owen-mc
owen-mc reviewed Jul 1, 2023
View reviewed changes
@ginsbach @owen-mc
Update docs/codeql/ql-language-reference/ql-language-specification.rst
cff8861 
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
@ginsbach ginsbach assigned alexet and unassigned alexet Jul 5, 2023
alexet
alexet approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@alexet alexet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need some logic on how final aliases work? I'm not sure the current text really covers them.

@ginsbach ginsbach merged commit 2ec5e72 into main Jul 5, 2023
@ginsbach ginsbach deleted the ginsbach/SpecifyExtendsFinal branch July 5, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-mc owen-mc owen-mc left review comments

@alexet alexet alexet approved these changes

Assignees

@alexet alexet

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ginsbach @alexet @owen-mc