Skip to content

C++: Support pointer addition and subtraction in the IRGuards library #13682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jul 6, 2023

It seems this was something supported by the AST Guards library.

It seems this was something supported by the AST Guards library
@github-actions github-actions bot added the C++ label Jul 6, 2023
@jketema jketema marked this pull request as ready for review July 6, 2023 14:57
@jketema jketema requested a review from a team as a code owner July 6, 2023 14:57
MathiasVP
MathiasVP previously approved these changes Jul 6, 2023
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if DCA is happy!

@jketema
Copy link
Contributor Author

jketema commented Jul 6, 2023

I'll add a change note once I know DCA is happy.

@jketema
Copy link
Contributor Author

jketema commented Jul 7, 2023

DCA looks uneventful. I've also added a change note.

@MathiasVP MathiasVP merged commit a826c83 into github:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants