Ruby: exclude Object class from API graph #13683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
calumgrant
reviewed
Jul 7, 2023
| /** Instances of `mod` with epsilon edges to its descendents, and to its upward node. */ | ||
| MkModuleInstanceDown(DataFlow::ModuleNode mod) or |
There was a problem hiding this comment.
Does it make sense to create an abstraction/class/predicate to capture this repeated logic?
There was a problem hiding this comment.
It would conflict with some of the follow-up changes I mentioned in my update so I decided to just keep it simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit unreverts #13496, which was previously reverted in #13620 due to performance issues.
The second commit fixes the performance issue by excluding
Objectfrom the API graph's model of the class hierarchy. API graphs aren't generally suitable for resolving methods onObjectso there isn't a need for it. It caused the graph shape to become expensive forfastTCand also avoids problems with top-levelincludestatements adding ancestors toObject.