Skip to content

C#: Use nuget.config file for dotnet restore fallback logic #13687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Jul 7, 2023

The PR takes into account the nuget.config file in the repo, when doing dotnet restore on individual packages. If there are multiple nuget.config files, we're looking for one in the root folder.

On dotnet/wcf, this change helps restore 3 out of the 7 previously not restored packages.

@tamasvajk tamasvajk requested a review from a team as a code owner July 7, 2023 11:50
@tamasvajk tamasvajk requested a review from michaelnebel July 7, 2023 11:50
@github-actions github-actions bot added the C# label Jul 7, 2023
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement!! :-)

@tamasvajk tamasvajk force-pushed the standalone/nugetconfig branch from 105bb31 to 23f3e44 Compare July 7, 2023 12:47
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tamasvajk tamasvajk merged commit 9cef290 into github:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants