Skip to content

Kotlin: Improve file class support #13718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 12, 2023
Merged

Kotlin: Improve file class support #13718

merged 5 commits into from
Jul 12, 2023

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Jul 11, 2023 •
edited
Loading

  • Adds Class.isFileClass()
  • Records classes as being "file class"es if the compiler tells us that they are
  • Adds some tests

igfoo added 3 commits July 11, 2023 15:58
@igfoo
Kotlin: Add an integration test for file classes
2162530
@igfoo
Kotlin: Add Class.isFileClass()
cfd29de
@igfoo
Kotlin: Record "file class" info from the compiler
6dedd92 
We were making file classes when the parent was a file, but not when it
was a class marked as one.
@igfoo igfoo force-pushed the igfoo/file_classes branch from 75a6b11 to 6dedd92 Compare July 11, 2023 14:58
@igfoo igfoo closed this Jul 11, 2023
@igfoo igfoo reopened this Jul 11, 2023
intrigus-lgtm
intrigus-lgtm reviewed Jul 11, 2023
View reviewed changes
@igfoo @intrigus-lgtm
Add missing "a" to a qldoc comment
75c835c 
Co-authored-by: intrigus-lgtm <60750685+intrigus-lgtm@users.noreply.github.com>
@igfoo igfoo marked this pull request as ready for review July 12, 2023 12:45
@igfoo igfoo requested review from a team as code owners July 12, 2023 12:45
@igfoo igfoo merged commit fe24cc1 into github:main Jul 12, 2023
@igfoo igfoo deleted the igfoo/file_classes branch July 12, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@intrigus-lgtm intrigus-lgtm intrigus-lgtm left review comments

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Java Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igfoo @tamasvajk @intrigus-lgtm