Java: Exclude source-to-source flow in 5 queries. #13754
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
atorralba
approved these changes
Jul 17, 2023
I think it mostly will be. This definitely cuts drastically down on the number of results, so it's going to help a lot. How the end-to-end time for path calculation for the entire query suite is going to look after this, I don't know though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain projects there can be a lot of source-to-source flow, which can cause a cartesian explosion in the number of results for queries that already tends to have many results for such projects. A recent QA run identified these 5 queries to be the worst offenders in this regard.
Should fix https://github.com/github/codeql-java-team/issues/325