Go: Fix missing flow through receiver for function variable #13767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a function is assigned to a variable and called through that variable then we previously didn't realise it was a function. With this change we try use local flow to determine if the function being called is a method.
owen-mc
force-pushed
the
go/missing-flow-through-receiver
branch
from
70004aa to
de8794e
Compare
|
Don't mind the change; either defining method-call-node to be a thing with calling syntax We shouldn't modify Method.getTarget, because this explicitly refers to the method that is syntactically addressed at the callsite, and in the case of a function pointer there is no such method. |
This is not required, because getReceiver is still defined on CallNode, but is done for consistency.
smowton
previously approved these changes
Jul 19, 2023
smowton
approved these changes
Jul 19, 2023
This was referenced Jul 19, 2023
Closed
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assigning a method to a function variable (
f := a.b) and calling it using the variable (f(arg1, arg2)), we were losing any possible flow to the receiver of the method.