Skip to content

C++: Use Declaration.isTopLevel() in GlobalNamespace.getADeclaration() #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2018
Merged

C++: Use Declaration.isTopLevel() in GlobalNamespace.getADeclaration() #138

merged 1 commit into from
Sep 4, 2018

Conversation

ian-semmle
Copy link
Contributor

This additionally rules out UserType.isLocal and friend declarations, but that sounds correct to me.

@ian-semmle ian-semmle added the C++ label Sep 3, 2018
@ian-semmle ian-semmle mentioned this pull request Sep 3, 2018
Merged
jbj
jbj approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on a C++ snapshot, and the only difference I saw was that friend declarations went away. That seems right.

@jbj jbj merged commit 73675e2 into github:master Sep 4, 2018
@ian-semmle ian-semmle deleted the topLevel branch September 4, 2018 10:29
aibaars added a commit that referenced this pull request Oct 14, 2021
@aibaars
Merge pull request #138 from github/aibaars/part-1
370135f 
AST: getChild/getParent
smowton pushed a commit to smowton/codeql that referenced this pull request Dec 6, 2021
@igfoo
Merge pull request github#138 from github/igfoo/cfg
a99790b 
Kotlin: CFG improvements, and consistency check
erik-krogh added a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
@erik-krogh
Merge pull request github#138 from github/erik-krogh/bump-this
fe1a473 
bump the severity of `ql/implicit-this`
erik-krogh added a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
@erik-krogh
QL: Merge pull request github#138 from github/erik-krogh/bump-this
a722aeb 
bump the severity of `ql/implicit-this`
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
@MathiasVP
Merge pull request github#138 from microsoft/powershell-tainted-comma…
86a40b9 
…nd-query

PS: Add the first non-experimental query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbj jbj jbj approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-semmle @jbj