Skip to content

Revert "Swift: Pragmatic fix for CustomUrlSchemes.qll." #13888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2023
Merged

Revert "Swift: Pragmatic fix for CustomUrlSchemes.qll." #13888

merged 1 commit into from
Aug 7, 2023

Conversation

sashabu
Copy link
Contributor

@sashabu sashabu commented Aug 4, 2023 •
edited
Loading

Reverts #13757 since the underlying issue appears to have been fixed.

@github-actions github-actions bot added the Swift label Aug 4, 2023
@sashabu sashabu marked this pull request as ready for review August 4, 2023 17:11
@sashabu sashabu requested a review from a team as a code owner August 4, 2023 17:11
@sashabu sashabu requested a review from geoffw0 August 4, 2023 17:11
@sashabu sashabu added the no-change-note-required This PR does not need a change note label Aug 4, 2023
@geoffw0
Copy link
Contributor

geoffw0 commented Aug 7, 2023

From the previous PR:

On `OversecuredVulnerableiOSApp` itself:
before this change:
  flow sources: 39
  flow sources in `AppDelegate.swift`: 0
  taint reach: 434
after this change:
  flow sources: 40
  flow sources in `AppDelegate.swift`: 1
  taint reach: 500

... and now (on current main with a more up-to-date OversecuredVulnerableiOSApp snapshot) ...

before the change:
  flow sources: 68
  flow sources in `AppDelegate.swift`: 1
  taint reach: 552
after this revert:
  flow sources: 68
  flow sources in `AppDelegate.swift`: 1
  taint reach: 552

So I agree, the underlying issue appears to have been fixed.

@MathiasVP MathiasVP merged commit e14e0cd into main Aug 7, 2023
@MathiasVP MathiasVP deleted the revert-13757-sources branch August 7, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sashabu @geoffw0 @MathiasVP