CPP: Make FunctionWithWrappers toCause work on builtins.
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbj
reviewed
Sep 4, 2018
| private import TaintTracking | ||
|
|
||
| private | ||
| bindingset[index] |
There was a problem hiding this comment.
Using bindingset makes the function inline, which can make it harder to predict how it'll be optimised in future contexts. Do these unnamed parameters at least have a Parameter object? Then you should be able to add exists(func.getParameter(index)) after the or and remove the bindingset annotation.
There was a problem hiding this comment.
I tried that and I didn't get the same results (and the test fails). I believe getParameter had no results.
Because this predicate is private, any non-local performance effects due to inlining should be localized to within this library.
jbj
approved these changes
Sep 4, 2018
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
printAst: use the user-facing AST library
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Dec 6, 2021
Kotlin: Add SAFE_CAST support
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
…cfg-successors PS: Fix multiple CFG successors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it wouldn't return a result if the function didn't have parameter names. This affected anyone working with the library on builtin functions.