Java: limit field flow when tracking regex strings #13916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be already fixed by #13987. Nonetheless, since you mentioned that other languages already apply this limitation, should we also add it as an additional precaution? |
atorralba
approved these changes
Aug 18, 2023
|
It's a bit sad that we have to restrict flow so much in this way. The fieldFlowBranchLimit is a rather blunt tool that's certain to introduce more FNs, so it would be nice to eventually improve on the underlying reasons for the poor performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix #13752
(Someone else confirm that?)
Other languages already have a similar limitation in how they track regular expressions.
An evaluation looks slightly weird, but I think it's good.