C++: Remove unnecessary predicates #13920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction0` were broken and for some reason only handled the case where calls mapped to raw indirect nodes :wat:. It turns out these predicates weren't actually needed anyway.
|
We seem to have some broken tests. |
Thanks for the heads up. Looks like two tests that I just need to accept in the internal repo. I'll open a PR for that right away. |
MathiasVP
added
the
depends on internal PR
jketema
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predicates
indirectReturnOutNodeOperand0andindirectReturnOutNodeInstruction0were restricted to raw operand and instruction nodes for some reason 🤔, and this restriction was breaking some dataflow tests in my upcoming change to fix dataflow after our frontend upgrade.It turns out these predicates totally aren't needed 🎉.