Skip to content

Ruby: Fix another bug in isCapturedAccess #13939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2023
Merged

Ruby: Fix another bug in isCapturedAccess #13939

merged 1 commit into from
Aug 11, 2023

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Aug 10, 2023

#13936 follow-up; turns out we still treated non-self accesses in the top-level CFG scope as being captured accesses, which we shouldn't.

@github-actions github-actions bot added the Ruby label Aug 10, 2023
@hvitved hvitved marked this pull request as ready for review August 10, 2023 18:07
@hvitved hvitved requested a review from a team as a code owner August 10, 2023 18:07
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Aug 10, 2023
@hvitved hvitved merged commit c95b586 into github:main Aug 11, 2023
@hvitved hvitved deleted the ruby/captured-access-fix2 branch August 11, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hmac hmac hmac approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @hmac